Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: export workerData to ESM workers #25768

Closed
wants to merge 2 commits into from
Closed

worker: export workerData to ESM workers #25768

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

Fixes: #25765

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added esm Issues and PRs related to the ECMAScript Modules implementation. worker Issues and PRs related to Worker support. labels Jan 28, 2019
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2420/pipeline

@addaleax addaleax mentioned this pull request Jan 28, 2019
Closed
@addaleax
Copy link
Member Author

addaleax commented Jan 28, 2019 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/20374/ (:heavy_check_mark:)

devsnek
devsnek reviewed Jan 28, 2019
View reviewed changes
lib/worker_threads.js Outdated Show resolved Hide resolved
@GeorgeTaveras1231
Copy link

Impressive how quickly this was addressed. Thanks @addaleax!

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2019
@addaleax
Copy link
Member Author

Landed in 8919169

@addaleax addaleax closed this Jan 30, 2019
@addaleax addaleax deleted the worker-data-esm branch January 30, 2019 17:16
addaleax added a commit that referenced this pull request Jan 30, 2019
@addaleax
worker: export workerData to ESM workers
8919169 
Fixes: #25765

PR-URL: #25768
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jan 30, 2019
@addaleax @targos
worker: export workerData to ESM workers
e0597a7 
Fixes: #25765

PR-URL: #25768
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workerData export not available when using ES Modules
9 participants
@addaleax @nodejs-github-bot @GeorgeTaveras1231 @jasnell @Fishrock123 @lpinca @TimothyGu @cjihrig @devsnek