Skip to content

process: simplify report uncaught exception logic #25744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

process: simplify report uncaught exception logic #25744

merged 1 commit into from
Jan 31, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 27, 2019

This commit combines two if statements into a single if statement.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2408/pipeline

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Jan 27, 2019
BridgeAR
BridgeAR approved these changes Jan 27, 2019
View reviewed changes
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 31, 2019

Green CI: https://ci.nodejs.org/job/node-test-commit/25463/

@cjihrig
process: simplify report uncaught exception logic
dc1d331 
This commit combines two if statements into a single if
statement. Another if statement is replaced with a ternary.

PR-URL: nodejs#25744
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@cjihrig cjihrig merged commit dc1d331 into nodejs:master Jan 31, 2019
@cjihrig cjihrig deleted the ifs branch January 31, 2019 00:46
addaleax pushed a commit that referenced this pull request Feb 1, 2019
@cjihrig @addaleax
process: simplify report uncaught exception logic
cc253b5 
This commit combines two if statements into a single if
statement. Another if statement is replaced with a ternary.

PR-URL: #25744
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cjihrig @nodejs-github-bot @addaleax @richardlau @devsnek @BridgeAR