doc: add note regarding pushing release tags #25569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags shouldn't be pushed unless the remainder of release steps are able to be completed.
cjihrig
approved these changes
Jan 18, 2019
Contributor
Author
|
I'm ooo until Tuesday, if anyone wants to push fixes to this please
feel free
…On Fri, Jan 18, 2019, 1:06 PM Vse Mozhet Byt ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In doc/releases.md
<#25569 (comment)>:
> @@ -473,6 +473,9 @@ following command:
$ git push <remote> <vx.y.z>
```
+*Note*: Please do not push the tag unless you are ready to complete the remainder of the release
Nit: it seems this file is also wrapped at 80 characters.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25569 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAecV8AB7-D9mnkuuyrHL4vHwO1dLfkAks5vEg0ygaJpZM4aIS-x>
.
|
codebytere
approved these changes
Jan 22, 2019
BethGriggs
approved these changes
Jan 23, 2019
BridgeAR
approved these changes
Jan 23, 2019
BridgeAR
approved these changes
Jan 23, 2019
vsemozhetbyt
added
the
author ready
Contributor
Author
|
landed in 0d31293 |
MylesBorins
added a commit
that referenced
this pull request
Jan 24, 2019
Tags shouldn't be pushed unless the remainder of release steps are able to be completed. PR-URL: #25569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
added a commit
that referenced
this pull request
Jan 24, 2019
Tags shouldn't be pushed unless the remainder of release steps are able to be completed. PR-URL: #25569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
Tags shouldn't be pushed unless the remainder of release steps are able to be completed. PR-URL: #25569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
Tags shouldn't be pushed unless the remainder of release steps are able to be completed. PR-URL: #25569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
added a commit
that referenced
this pull request
May 16, 2019
Tags shouldn't be pushed unless the remainder of release steps are able to be completed. PR-URL: #25569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags shouldn't be pushed unless the remainder of release steps are able
to be completed.