Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: mark options parsers as const #25065

Closed
wants to merge 1 commit into from
Closed

src: mark options parsers as const #25065

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

These do not change their contents after being constructed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: mark options parsers as const
9d5aca5 
These do not change their contents after being constructed.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1963/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 15, 2018
@danbev
Copy link
Contributor

danbev commented Dec 19, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19673/

@danbev
Copy link
Contributor

danbev commented Dec 20, 2018 •
edited
Loading

Re-run of failing node-test-commit-smartos ✔️

@danbev
Copy link
Contributor

danbev commented Dec 20, 2018

Landed in 6b7816e.

@danbev danbev closed this Dec 20, 2018
danbev pushed a commit that referenced this pull request Dec 20, 2018
@addaleax @danbev
src: mark options parsers as const
6b7816e 
These do not change their contents after being constructed.

PR-URL: #25065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@addaleax @MylesBorins
src: mark options parsers as const
f213a05 
These do not change their contents after being constructed.

PR-URL: #25065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 25, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@addaleax @MylesBorins
src: mark options parsers as const
fd0361b 
These do not change their contents after being constructed.

PR-URL: #25065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
src: mark options parsers as const
eec6433 
These do not change their contents after being constructed.

PR-URL: nodejs#25065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @nodejs-github-bot @danbev @jasnell @cjihrig @joyeecheung @BethGriggs