src: pass isMainThread into bootstrap/node.js directly #25017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of loading the working binding for the sole purpose of detecting whether we are inside the main thread unconditionally.
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Dec 14, 2018
devsnek
approved these changes
Dec 14, 2018
addaleax
added
the
author ready
jasnell
approved these changes
Dec 15, 2018
|
Landed in 7a6bd9f |
addaleax
pushed a commit
that referenced
this pull request
Dec 15, 2018
Instead of loading the working binding for the sole purpose of detecting whether we are inside the main thread unconditionally. PR-URL: #25017 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
|
This does not land cleanly on v11.x, is someone willing to do a backport? |
|
Also cherry-picked with a minor conflict resolution in |
addaleax
pushed a commit
that referenced
this pull request
Jan 14, 2019
Instead of loading the working binding for the sole purpose of detecting whether we are inside the main thread unconditionally. PR-URL: #25017 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Instead of loading the working binding for the sole purpose of detecting whether we are inside the main thread unconditionally. PR-URL: nodejs#25017 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
Instead of loading the working binding for the sole purpose of detecting whether we are inside the main thread unconditionally. PR-URL: nodejs#25017 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading the worker binding for the sole purpose of
detecting whether we are inside the main thread unconditionally.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes