lib: remove internalBinding('config').pendingDeprecation#24962
Closed
joyeecheung wants to merge 2 commits intonodejs:masterfrom
Closed
lib: remove internalBinding('config').pendingDeprecation#24962joyeecheung wants to merge 2 commits intonodejs:masterfrom
joyeecheung wants to merge 2 commits intonodejs:masterfrom
Conversation
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`
nodejs-github-bot
added
buffer
jasnell
approved these changes
Dec 11, 2018
addaleax
approved these changes
Dec 11, 2018
cjihrig
approved these changes
Dec 12, 2018
BridgeAR
approved these changes
Dec 12, 2018
| case 'switch': | ||
| assert.strictEqual(config.pendingDeprecation, true); | ||
| assert.strictEqual( | ||
| require('internal/options').getOptionValue('--pending-deprecation'), |
Member
There was a problem hiding this comment.
I suggest to move this to the top of the file as in: const { getOptionvalue } = require('internal/options');. It's always loaded anyway.
joyeecheung
added
the
author ready
Member
|
Only failure in CI was AIX which failed because there was a leftover process at the end of all the tests. 😱Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19552/ ✔️ |
Member
|
Landed in b32e5e0 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 15, 2018
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`
PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
sagitsofan
pushed a commit
to sagitsofan/node
that referenced
this pull request
Dec 24, 2018
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`
PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
|
This does not land cleanly on v11.x, would someone be willing to backport? |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 9, 2019
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`
PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
4 tasks
BridgeAR
pushed a commit
that referenced
this pull request
Jan 10, 2019
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`
PR-URL: #24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
joyeecheung
added a commit
to joyeecheung/node
that referenced
this pull request
Jan 11, 2019
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`
PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Jan 14, 2019
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`
PR-URL: #24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Backport-PR-URL: #25446
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`
PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`
PR-URL: nodejs#24962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Backport-PR-URL: nodejs#25446
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead use
require('internal/options').getOptionValue('--pending-deprecation')Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes