Skip to content

Conversation

@ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 9, 2018

Pulls out the common argument validateObject validator to internal/validators.

BTW, there is inconsistent ERR_INVALID_ARG_TYPE via the object validation: object or Object, do we need to unify this error message ? Although this is so trivial :)

throw new ERR_INVALID_ARG_TYPE('pathObject', 'Object', pathObject);

throw new ERR_INVALID_ARG_TYPE('args', 'object', args);

Update: unify the error message by lowercase object(should be semver-major?)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. crypto Issues and PRs related to the crypto subsystem. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Dec 9, 2018
@mscdex
Copy link
Contributor

mscdex commented Dec 9, 2018

FWIW this conflicts with #24913

@ofrobots ofrobots removed the trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. label Feb 14, 2019
@ZYSzys ZYSzys closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants