Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: list all versions WHATWG URL api was added #24847

Closed
wants to merge 1 commit into from

Conversation

watson
Copy link
Member

@watson watson commented Dec 5, 2018

Originally WHATWG URL api support was added in v7.x but was later backported to v6.13.0. This PR updates the docs to show support for the WHATWG URL api in that version + adds missing added: info to a few functions that were missing it which were added in in v10.12.0.

Question: Should I remove v7.0.0 from the added: list, or does it give historical context to see that it was added to v7.0.0 first and then later backported to v6.13.0? Update: After I've seen it rendered, I think it makes sense to show both.

Checklist

@watson watson self-assigned this Dec 5, 2018
@nodejs-github-bot
Copy link
Collaborator

@watson sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Dec 5, 2018
@watson
Copy link
Member Author

watson commented Dec 5, 2018

Just discovered a few other places in the URL docs where the added: field needs to be updated. I'll push a new commit soon

@watson watson changed the title doc: show WHATWG URL api support in v6.13.0 doc: list all versions WHATWG URL api was added Dec 5, 2018
@watson
Copy link
Member Author

watson commented Dec 5, 2018

I updated the PR to be a complete makeover of the added: attribute for all the WHATWG URL functions.

Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, I think its a general problem in the YAML annotations, I added a issue to track it: #24850

@watson watson added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 5, 2018
@watson
Copy link
Member Author

watson commented Dec 5, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@watson
Copy link
Member Author

watson commented Dec 5, 2018

@sam-github forgot to mention you in the above comment, so here it goes ^

@Trott
Copy link
Member

Trott commented Dec 5, 2018

Landed in 7868b6a

@Trott Trott closed this Dec 5, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2018
PR-URL: nodejs#24847
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@watson watson deleted the url-docs branch December 5, 2018 23:14
BridgeAR pushed a commit that referenced this pull request Dec 6, 2018
PR-URL: #24847
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 6, 2018
4 tasks
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
PR-URL: #24847
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
PR-URL: #24847
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24847
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
PR-URL: #24847
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
PR-URL: #24847
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #24847
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants