Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x] Revert "util: change %o depth default" #24806

Closed
wants to merge 1 commit into from
Closed

[v11.x] Revert "util: change %o depth default" #24806

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Dec 3, 2018

This reverts commit 1a1fe53.

This was part of another PR of which the first commit was reverted. This change alone was however not intended. Since this change was done by accident on master already (a faulty rebase in a different PR) this is only here as a backport for v11.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1803/pipeline

@nodejs-github-bot nodejs-github-bot added util Issues and PRs related to the built-in util module. v11.x labels Dec 3, 2018
@BridgeAR BridgeAR requested a review from devsnek December 3, 2018 14:15
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 4, 2018 •
edited by Trott
Loading

CI https://ci.nodejs.org/job/node-test-pull-request/19192/ ✔️

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 4, 2018
@addaleax addaleax changed the title Revert "util: change %o depth default" [v11.x] Revert "util: change %o depth default" Dec 5, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 5, 2018

Landed in 764d76f

@BridgeAR BridgeAR closed this Dec 5, 2018
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@BridgeAR
Revert "util: change %o depth default"
764d76f 
This reverts commit 1a1fe53.

PR-URL: #24806
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
@BridgeAR BridgeAR deleted the revert-util-o-default branch January 20, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BridgeAR @nodejs-github-bot @Fishrock123 @devsnek @BethGriggs