[v6.x] http: fix backport of Slowris headers #24796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nodejs/release @nodejs/tsc this would need to be released ASAP, Node v6.x is currently broken. |
rvagg
approved these changes
Dec 3, 2018
richardlau
approved these changes
Dec 3, 2018
addaleax
changed the title
addaleax
approved these changes
Dec 3, 2018
|
@mcollina commit summary needs to be changed: "Slowris" -> "Slowloris" |
|
v6.x-staging is not up-to-date, and it's prerogative to the @nodejs/release time to get it up to date. As such, I've targeted v6.x. |
|
@addaleax 6.x is appropriate, we can ship a release with only this commit. There's some things waiting on staging that probably should pollute a release to minimise safety concerns for users. |
The backport of nodejs@618eebdd17 was not complete, and the starting time to parse the headers was not reset. Fixes: nodejs#24760
|
@rvagg done, PTAL |
mcollina
force-pushed
the
fix-reset-on-keepalive
branch
from
b8d857a
to
4341817
Compare
rvagg
pushed a commit
that referenced
this pull request
Dec 3, 2018
The backport of 618eebdd17 was not complete, and the starting time to parse the headers was not reset. PR-URL: #24796 Fixes: #24760 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed, expedited, 5d9005c. There's no reason to delay on this is there? |
|
There is not. |
rvagg
added a commit
that referenced
this pull request
Dec 3, 2018
Notable Changes: This is a patch release to address a bad backport of the fix for "Slowloris HTTP Denial of Service" (CVE-2018-12122). Node.js 6.15.0 misapplies the headers timeout to an entire keep-alive HTTP session, resulting in prematurely disconnected sockets. PR-URL: #24803 Refs: #24796 Refs: #24760 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
rvagg
added a commit
that referenced
this pull request
Dec 3, 2018
Notable Changes: This is a patch release to address a bad backport of the fix for "Slowloris HTTP Denial of Service" (CVE-2018-12122). Node.js 6.15.0 misapplies the headers timeout to an entire keep-alive HTTP session, resulting in prematurely disconnected sockets. PR-URL: #24803 Refs: #24796 Refs: #24760 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced Dec 5, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Notable Changes: This is a patch release to address a bad backport of the fix for "Slowloris HTTP Denial of Service" (CVE-2018-12122). Node.js 6.15.0 misapplies the headers timeout to an entire keep-alive HTTP session, resulting in prematurely disconnected sockets. PR-URL: nodejs#24803 Refs: nodejs#24796 Refs: nodejs#24760 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backport of 618eebdd17 was
not complete, and the starting time to parse the headers was not reset.
Fixes: #24760
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes