-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replace anonymous function with arrow function #24528
Conversation
While these kinds of commits are 👍 for first-contributions, I'm not sure they're of sufficient value to warrant a bunch of pull requests from existing contributors. I'd prefer people try to do something a bit more meaningful for subsequent commits. What do other Collaborators think? (If we really want this type of thing to get done quickly instead of be a good exercise for new contributors, this is the type of thing that can be easily done with an ESLint rule and a |
Hello @codegagan, Also be aware that you might get push-back. I think that is only natural, as we do expect more and more as you become more of an experienced contributor. If I may suggest, we have a large list of stalled Issues and PR, you could take a look at those. They are things that could benefit the project, but need a champion to push them over the line. |
IIRC there were some code and learners whom we provided extra assignment slip(s) to be completed as In either case, I concur to @Trott and @refack on the proposal on taking up bigger contribution ventures moving forward; at the same time feel happy to see @codegagan coming back to the repo. Wishing you great success with Node.js! |
ok, now looking at the PR list I see there are 5 or 6 - so these are not my assignments but hand-picks . In a way it is good that you were able to search and find things of your own, but it makes sense to be contented with the list of arrow function assignments as of now. :) @codegagan - one thing that comes to my mind is preparing C++ code (/src) for v8 deprecation. Talking to @ryzokuken this is what it is I think:
/cc @ryzokuken to confirm my understanding / providing more direct instructions. thanks! |
@refack , @gireeshpunathil Thankyou for the guidance.
@gireeshpunathil regarding the v8 deprecation task, do you think it would be more appropriate to have instructions in an issue (than here) ? I can create one and paste these and then look into it. |
make sense to me, thanks! |
Re-run of failing node-test-commit-windows-fanned/. |
windows-fanned->vs17->test-trace-events-api-worker-disabled is a known failure, landing. |
landed as db84fd2 |
PR-URL: #24528 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #24528 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #24528 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: nodejs#24528 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #24528 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #24528 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes