-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix c++ code coverage on macOS #24520
Conversation
@refack sadly an error occured when I tried to trigger a build :( |
/CC @nodejs/build-files @nodejs/gyp |
I tested this on https://ci.nodejs.org/computer/test-macstadium-macos10.12-x64-1/, and it builds and links But I get this from
P.S. it's actually just the node binary:
|
/CC @nodejs/build-files @nodejs/gyp (CI had just a flake) |
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19111/ |
PR-URL: nodejs#24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
2818472
to
eb6741b
Compare
Landed in eb6741b |
PR-URL: #24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: nodejs#24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Alternative to #24004
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes