Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: replace unreachable error with assertion #24407

Closed
wants to merge 1 commit into from
Closed

http2: replace unreachable error with assertion #24407

wants to merge 1 commit into from

Commits on Nov 16, 2018

  1. http2: replace unreachable error with assertion 

    "That particular `emit('error', ...)` is largely defensively coded and
should not ever actually happen." Sounds like an assertion rather than
an error event. The code in question has no test coverage because it is
believed to be unreachable.

Fixes: nodejs#20673
    @Trott
    Trott committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    34e1a56 View commit details
    Browse the repository at this point in the history