Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove argument and fix import #24375

Closed
wants to merge 3 commits into from
+2 −2
Closed

test: remove argument and fix import #24375

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
340d527
test: use destructuring for spawn import in test-pipewrap.js
jkmdev Nov 15, 2018
cd9eb17
test: remove unused argument for onsleepExit() in test-pipewrap.js
jkmdev Nov 15, 2018
6fc34ff
test: fix spawn import in test-pipewrap.js
jkmdev Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/async-hooks/test-pipewrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const assert = require('assert');
const tick = require('../common/tick');
const initHooks = require('./init-hooks');
const { checkInvocations } = require('./hook-checks');
const spawn = require('child_process').spawn;
const { spawn } = require('child_process');

if (!common.isMainThread)
common.skip('Worker bootstrapping works differently -> different async IDs');
Expand Down Expand Up @@ -45,7 +45,7 @@ checkInvocations(processwrap, { init: 1 },
checkInvocations(x, { init: 1 }, 'pipe wrap when sleep.spawn was called');
});

function onsleepExit(code) {
function onsleepExit() {
checkInvocations(processwrap, { init: 1, before: 1 },
'processwrap while in onsleepExit callback');
}
Expand Down