Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable openssl asm on arm64 for now #24270

Closed

Conversation

bnoordhuis
Copy link
Member

There is reason to believe the generated assembly isn't working
correctly so let's disable it for now pending further investigation.

Refs: #23913

There is reason to believe the generated assembly isn't working
correctly so let's disable it for now pending further investigation.

Refs: nodejs#23913
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency. labels Nov 9, 2018
@refack refack added the arm Issues and PRs related to the ARM platform. label Nov 9, 2018
@refack
Copy link
Contributor

refack commented Nov 11, 2018

@danbev
Copy link
Contributor

danbev commented Nov 12, 2018

Re-run of failing node-test-commit-smartos ✔️

@danbev
Copy link
Contributor

danbev commented Nov 12, 2018

Landed in 4684de6.

@danbev danbev closed this Nov 12, 2018
pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Nov 12, 2018
There is reason to believe the generated assembly isn't working
correctly so let's disable it for now pending further investigation.

PR-URL: nodejs#24270
Refs: nodejs#23913
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
There is reason to believe the generated assembly isn't working
correctly so let's disable it for now pending further investigation.

PR-URL: #24270
Refs: #23913
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
There is reason to believe the generated assembly isn't working
correctly so let's disable it for now pending further investigation.

PR-URL: nodejs#24270
Refs: nodejs#23913
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants