Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: deep object to console table not covered #24257

Closed
wants to merge 1 commit into from
Closed

test: deep object to console table not covered #24257

wants to merge 1 commit into from

Conversation

ovhemert
Copy link
Contributor

@ovhemert ovhemert commented Nov 8, 2018

Console table output for objects more than 2 levels deep is was covered by tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 8, 2018
starkwang
starkwang approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@starkwang starkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Nov 10, 2018

CI queued up here: https://ci.nodejs.org/job/node-test-pull-request/18504/

The link is not currently active as the CI is catching up on a few other jobs.

@danbev
Copy link
Contributor

danbev commented Nov 15, 2018

Landed in ed15b33.

@danbev danbev closed this Nov 15, 2018
danbev pushed a commit that referenced this pull request Nov 15, 2018
@ovhemert @danbev
test: deep object to table not covered
ed15b33 
PR-URL: #24257
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Nov 15, 2018
@ovhemert @BridgeAR
test: deep object to table not covered
dc26247 
PR-URL: #24257
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Nov 15, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@ovhemert @codebytere
test: deep object to table not covered
6cad1b6 
PR-URL: #24257
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starkwang starkwang starkwang approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ovhemert @jasnell @danbev @lpinca @BridgeAR @starkwang @nodejs-github-bot