src, test: fix V8 compiler warnings #24246
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Contributor
Author
addaleax
approved these changes
Nov 8, 2018
Contributor
Author
|
Re-run of failing node-test-commit-windows-fanned. |
Contributor
+1 for squashing all |
danbev
force-pushed
the
v8_compiler_warnings
branch
from
02979eb to
7cfe2cf
Compare
Contributor
|
@refack is this in a state that it can be rebased, squashed, and landed? The compiler warnings are currently a bit much 😄 |
refack
approved these changes
Nov 10, 2018
Contributor
Contributor
|
No rebase CI: https://ci.nodejs.org/job/node-test-pull-request/18515/ |
danbev
force-pushed
the
v8_compiler_warnings
branch
from
7cfe2cf to
2bd09a7
Compare
This commit changes the code to use the maybe version.
danbev
force-pushed
the
v8_compiler_warnings
branch
from
2bd09a7 to
1537d39
Compare
Contributor
Author
Contributor
Author
Contributor
Author
|
Re-run of failing /node-test-commit-freebsd ✔️ |
Contributor
Author
danbev
added a commit
that referenced
this pull request
Nov 11, 2018
This commit changes the code to use the maybe version. PR-URL: #24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
danbev
added a commit
that referenced
this pull request
Nov 11, 2018
PR-URL: #24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
This commit changes the code to use the maybe version. PR-URL: #24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
This commit changes the code to use the maybe version. PR-URL: nodejs#24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Nov 15, 2018
Member
|
@danbev this is a bit of a large backport and it definitely won't land cleanly, do you think it should be backported to |
Contributor
Author
|
@codebytere I think this can be skipped but if anyone thinks differently let me know and I can take a look at backporting it. |
codebytere
pushed a commit
that referenced
this pull request
Jan 12, 2019
PR-URL: #24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request follows up on #24060 and attempts to fix all the remaining v8 warnings regarding Set/Get.
There is currently one warning still being generated from [src/node.cc](a525283#diff-cd53544f44aab2c697bcd7b6a57f23ccR675-677)I've left a comment in the code as I was not sure how to get the correct context. Hopefully someone can help out and advise on this.The commits are currently separate for each C++ source file but can be squashed unless anyone objects.
make -j4 test(UNIX), orvcbuild test(Windows) passes