Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple project messaging. #24

Closed
wants to merge 1 commit into from
Closed

Simple project messaging. #24

wants to merge 1 commit into from

Conversation

mikeal
Copy link
Contributor

@mikeal mikeal commented Dec 2, 2014

This should put to bed some of the wilder speculation we've seen.

@rvagg
Copy link
Member

rvagg commented Dec 2, 2014

+1 for putting to bed "Evented I/O for V8 javascript", I've always hated that title

@max-mapper
Copy link
Contributor

your commit should be docs: add simple project messaging to readme :)

@mikeal
Copy link
Contributor Author

mikeal commented Dec 2, 2014

how do i alter commit messages after the fact?

@TJkrusinski
Copy link

git commit --amend

@mikeal
Copy link
Contributor Author

mikeal commented Dec 2, 2014

@TJkrusinski thanks! :)

@TJkrusinski
Copy link

no problem!

@indutny
Copy link
Member

indutny commented Dec 2, 2014

LGTM

@ralphtheninja
Copy link
Contributor

@mikeal Are you working on the governance section in https://github.com/mikeal/io.js/blob/readme-messaging/CONTRIBUTING.md#governance ?

@mikeal
Copy link
Contributor Author

mikeal commented Dec 2, 2014

@ralphtheninja
Copy link
Contributor

👍

releases, and contributorship are under an
[open governance model](./CONTRIBUTING.md#governance).

We intend to release, with increasing regularity, releases which are

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph is a bit awkward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I think it's supposed to say io.js is under the "open governance model" but it reads like node.js is. Not trying to be nitpicky. This is a pretty important paragraph.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinohara80 +1, would you or @KyleAMathews mind putting in a PR to clarify this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing that now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #36

mikeal added a commit that referenced this pull request Dec 2, 2014
Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: #24
@indutny
Copy link
Member

indutny commented Dec 2, 2014

Landed in 51514c8! Thank you.

@indutny indutny closed this Dec 2, 2014
kevinohara80 added a commit to kevinohara80/io.js that referenced this pull request Dec 10, 2014
rewords project messaging in README to make the overall
project messaging a bit clearer. More discussion to be
found in nodejs#24
bnoordhuis pushed a commit that referenced this pull request Dec 10, 2014
Rewords project messaging in README to make the overall project
messaging a bit clearer. More discussion to be found in #24.

PR-URL: #36
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants