doc: rename README section for Release Keys #23927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The section of the README currently labeled "Release Team" isn't about the team much and is very much about the keys. Rename it "Release Keys" so that it's purpose matches it's name.
vsemozhetbyt
approved these changes
Oct 27, 2018
targos
approved these changes
Oct 27, 2018
lpinca
approved these changes
Oct 27, 2018
vsemozhetbyt
added
the
author ready
mihalskiy
approved these changes
Oct 27, 2018
cjihrig
approved these changes
Oct 28, 2018
trivikr
approved these changes
Oct 29, 2018
jasnell
approved these changes
Oct 29, 2018
mmarchini
approved these changes
Oct 29, 2018
|
Landed in d7b95f1 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 29, 2018
The section of the README currently labeled "Release Team" isn't about the team much and is very much about the keys. Rename it "Release Keys" so that it's purpose matches it's name. PR-URL: nodejs#23927 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos
pushed a commit
that referenced
this pull request
Nov 1, 2018
The section of the README currently labeled "Release Team" isn't about the team much and is very much about the keys. Rename it "Release Keys" so that it's purpose matches it's name. PR-URL: #23927 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
This was referenced Nov 2, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Nov 26, 2018
The section of the README currently labeled "Release Team" isn't about the team much and is very much about the keys. Rename it "Release Keys" so that it's purpose matches it's name. PR-URL: #23927 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
|
I've backported to 10.x, but there is a chance this could break downstream tools that might be grepping our README to get keys. Don't think it should be an issue but want to note that this was considered when landing |
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
The section of the README currently labeled "Release Team" isn't about the team much and is very much about the keys. Rename it "Release Keys" so that it's purpose matches it's name. PR-URL: #23927 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
The section of the README currently labeled "Release Team" isn't about the team much and is very much about the keys. Rename it "Release Keys" so that it's purpose matches it's name. PR-URL: #23927 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The section of the README currently labeled "Release Team" isn't about
the team much and is very much about the keys. Rename it "Release Keys"
so that it's purpose matches it's name.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes