Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: spawn make test-ci with -j1 #23733

Merged
merged 1 commit into from
Oct 20, 2018
Merged

build: spawn make test-ci with -j1 #23733

merged 1 commit into from
Oct 20, 2018

Commits on Oct 20, 2018

  1. build: spawn make test-ci with -j1 

    All the sub targets have internal parallelism, so no performance loss.
Also `make` doesn't to a good enough job of combining the output
streams, or eliminate races.

PR-URL: nodejs#23733
Fixes: nodejs#22006
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    @refack
    refack committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    b3ae915 View commit details
    Browse the repository at this point in the history