doc: use Cookie in request.setHeader() examples #23707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Set-Cookie` is a response header, replace it with `Cookie`.
nodejs-github-bot
added
doc
cjihrig
approved these changes
Oct 17, 2018
vsemozhetbyt
approved these changes
Oct 17, 2018
jasnell
approved these changes
Oct 17, 2018
Member
|
Landed in 862b7a1 |
addaleax
pushed a commit
that referenced
this pull request
Oct 24, 2018
`Set-Cookie` is a response header, replace it with `Cookie`. PR-URL: #23707 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 24, 2018
`Set-Cookie` is a response header, replace it with `Cookie`. PR-URL: #23707 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 2, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Nov 26, 2018
`Set-Cookie` is a response header, replace it with `Cookie`. PR-URL: #23707 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
`Set-Cookie` is a response header, replace it with `Cookie`. PR-URL: #23707 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
`Set-Cookie` is a response header, replace it with `Cookie`. PR-URL: #23707 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set-Cookieis a response header, replace it withCookie.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes