test: check version strings have expected pattern

[sam-github]

Many were checked, but a few were not.

Should wait on #23678, which is included in this to make the openssl version check succeed and to avoid conflicts because of adjacent test assertions. I'll rebase after the other is merged.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1255/pipeline

[sam-github]

ci: https://ci.nodejs.org/job/node-test-pull-request/17880/

[refack]

LGTM on the second commit.
(The first one got 👍 in #23678)

[cjihrig]

This fails in the CI, but LGTM once it passes.

[richardlau]

This fails in the CI,

For reference:

not ok 1451 parallel/test-process-versions

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1604_sharedlibs_withoutintl_x64/7845/console

19:38:16 not ok 1451 parallel/test-process-versions
19:38:16   ---
19:38:16   duration_ms: 0.616
19:38:16   severity: fail
19:38:16   exitcode: 1
19:38:16   stack: |-
19:38:16     assert.js:351
19:38:16         throw err;
19:38:16         ^
19:38:16     
19:38:16     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
19:38:16     
19:38:16       assert(/^\d+\.\d+$/.test(process.versions.cldr))
19:38:16     
19:38:16         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_withoutintl_x64/test/parallel/test-process-versions.js:37:1)
19:38:16         at Module._compile (internal/modules/cjs/loader.js:707:30)
19:38:16         at Object.Module._extensions..js (internal/modules/cjs/loader.js:718:10)
19:38:16         at Module.load (internal/modules/cjs/loader.js:605:32)
19:38:16         at tryModuleLoad (internal/modules/cjs/loader.js:544:12)
19:38:16         at Function.Module._load (internal/modules/cjs/loader.js:536:3)
19:38:16         at Function.Module.runMain (internal/modules/cjs/loader.js:760:12)
19:38:16         at startup (internal/bootstrap/node.js:303:19)
19:38:16         at bootstrapNodeJSCore (internal/bootstrap/node.js:870:3)
19:38:16   ...

The version strings from ICU (process.versions.cldr, process.versions.icu and process.versions.unicode) should be guarded by common.hasIntl and process.versions.openssl test should be guarded by common.hasCrypto. I don't think the CI has a --without-ssl build.

[sam-github]

ci: https://ci.nodejs.org/job/node-test-pull-request/18064/

[sam-github]

ci: https://ci.nodejs.org/job/node-test-pull-request/18122/
ci: https://ci.nodejs.org/job/node-test-pull-request/18123/

[jasnell]

Resumed ci: https://ci.nodejs.org/job/node-test-pull-request/18127/

[sam-github]

versions.tz also needed protection for without-icu builds.

ci: https://ci.nodejs.org/job/node-test-pull-request/18128/

[sam-github]

Landed in f4225f0

[sam-github]

Landed in eb6b5c3