test: adding test coverage for SourceTextModule.evaluate #23595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks that invalid option throws an error.
targos
added
the
code-and-learn
jasnell
approved these changes
Oct 12, 2018
BridgeAR
approved these changes
Oct 12, 2018
addaleax
approved these changes
Oct 12, 2018
Member
|
(Also: Nice first contribution!) |
Member
addaleax
added
author ready
TimothyGu
approved these changes
Oct 12, 2018
Member
|
Collaborators, 👍 to approve fast-tracking this PR. UPDATE: @addaleax has 👍 this for fast-tracking offline. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 13, 2018
This checks that invalid option throws an error. PR-URL: nodejs#23595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Member
|
Landed in 6cd5c74 |
addaleax
pushed a commit
that referenced
this pull request
Oct 14, 2018
This checks that invalid option throws an error. PR-URL: #23595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
This checks that invalid option throws an error. PR-URL: #23595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
This checks that invalid option throws an error. PR-URL: #23595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
This checks that invalid option throws an error. PR-URL: #23595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
This checks that invalid option throws an error. PR-URL: #23595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that invalid option throws an error.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes