Conversation
|
Nice. 👍 |
|
I believe you could remove the |
src/node.cc
Outdated
There was a problem hiding this comment.
If the title is always empty, you might as well drop this variable and use String::Empty() below.
|
Left some comments. I think the help section should make it clear that the flag is not related to |
|
@bnoordhuis did the slight rephrasing help? will need to rebase/squash before pulling in |
|
@bnoordhuis LGTY? |
src/node.cc
Outdated
There was a problem hiding this comment.
Please capitalize and punctuate the comment.
|
@bmeck Can you rebase and squash to a single commit with a commit log conforming to the guidelines from CONTRIBUTING.md? Anyone have thoughts on the name of the switch? I'm partial to |
|
@bmeck @bnoordhuis ... any further updates on this? @bmeck it would need to be rebased and updated before it could land. |
|
Closing due to lack of activity or response |
simple way to start the cpu profiler when you application starts up using
--profile-cpu. useful for applications that need help profiling startup time.