src: remove unused UVHandle methods #23535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Oct 12, 2018
addaleax
added
the
code-and-learn
jasnell
approved these changes
Oct 12, 2018
|
I just talked to a mentor and they suggested a message to make sure CI is triggered for this - thank you! |
|
Oh, I see it is queued! Never mind - I'm a newbie! |
|
@MarianneDr We still have to kick off a full CI manually :) Also, I think this is not a trivial pull requests like many other Code&Learn PRs, so it may have to wait our standard 48 hours before we merge it – just as a heads up, it doesn’t mean that you have to do anything. |
addaleax
added
the
author ready
|
Shouldn't this at least go through CITGM? I'm not sure what variety of C++ addons we have in there, but it seems like removing a public method like this isn't safe to just remove (especially within an existing versioned branch)? |
|
Thank you for letting me know! Let me know what I need to do! |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 15, 2018
PR-URL: nodejs#23535 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 15, 2018
PR-URL: nodejs#23535 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 0d6f014 🎉 @MarianneDr congratulations on your commit to Node.js! |
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
PR-URL: #23535 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Oct 20, 2018
PR-URL: #23535 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
PR-URL: #23535 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #23535 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #23535 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes