src: change constructor behavior in stream_base-inl.h

[iansu]

Change ConstructorBehavior from kAllow to kThrow.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[addaleax]

@iansu Can you also remove the TODO comment itself, now that it’s done? :)

[addaleax]

@iansu This PR is very similar to #23453 – that’s my fault. One of the tasks we handed out had text pointing to the same file, even though the heading pointed to another file (node_crypto.cc).

I’ll try to land both of these PRs together so you both get full credit, but just a heads up, if you have the test with the heading mentioning node_crypto.cc, feel free to also do that! Sorry again. :(

[iansu]

@addaleax I can fix this in node_crypto.cc if it hasn't been done already. Should I do that here or in a new PR?

[addaleax]

@iansu We have #23582 for that – sorry for the confusion, should be all good now!

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/17839/

[addaleax]

Landed in c19ab56

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)