Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x backport] backport 23233, 22938 #23398

Closed
wants to merge 2 commits into from
Closed

[v10.x backport] backport 23233, 22938 #23398

wants to merge 2 commits into from

Commits on Oct 13, 2018

  1. src: ready background workers before bootstrap 

    Make sure background workers are ready before proceeding with the
bootstrap or post-bootstrap execution of any code that may trigger
`process.exit()`.

Fixes: nodejs#23065

PR-URL: nodejs#23233
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @ofrobots
    ofrobots committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    63f0e77 View commit details
    Browse the repository at this point in the history

  2. trace_events: destroy platform before tracing 

    For safer shutdown, we should destroy the platform – and background
threads - before the tracing infrastructure is destroyed. This change
fixes the relative order of NodePlatform disposition and the tracing
agent shutting down. This matches the nesting order for startup.

Make the tracing agent own the tracing controller instead of platform
to match the above.

Fixes: nodejs#22865

PR-URL: nodejs#22938
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @ofrobots
    ofrobots committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    afca579 View commit details
    Browse the repository at this point in the history