docs,meta: assign PR semantics #23292

refack · 2018-10-06T14:47:38Z

some refresh to wording.

/CC the non-existing @nodejs/colab-governance (for in lieu of pinging all Collaborators) :shrung:

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-10-06T14:47:39Z

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1140/pipeline

vsemozhetbyt · 2018-10-06T15:20:01Z

COLLABORATOR_GUIDE.md

-Check PRs from new contributors to make sure the person's name and email address
-are correct before merging.
+For PRs from first time contributors it is recommended to be
+[welcoming][#welcoming-first-time-contributors] and verify that the git settings


[#welcoming-first-time-contributors] -> (#welcoming-first-time-contributors) (otherwise, the link is not rendered).

vsemozhetbyt · 2018-10-06T15:24:28Z

Doc format and wording LGTM with a nit.
Not sure how to feel about one more rules to observe, though it seems valid as it secures a PR author.
Should the TSC chime in?

mscdex · 2018-10-06T16:04:34Z

COLLABORATOR_GUIDE.md

-   one](https://github.com/nodejs/node/commit/b636ba8186) if unsure exactly how
-   to format your commit messages.
+1. Add all necessary [metadata](#metadata) to commit messages before landing. If
+   You are unsure exactly how to format the commit messages, use the commit log


mscdex · 2018-10-06T16:08:07Z

COLLABORATOR_GUIDE.md

-   to format your commit messages.
+1. Add all necessary [metadata](#metadata) to commit messages before landing. If
+   You are unsure exactly how to format the commit messages, use the commit log
+   as a reference, for examples commits such as [this one][commit-example].


I think the sentence should end here at 'reference' and the last part re-worded. Perhaps something like 'See [this commit][commit-example] as an example.'

vsemozhetbyt · 2018-10-06T16:10:37Z

docs -> doc in commit title? It seems commmit linter is in action)

addaleax · 2018-10-06T16:42:20Z

COLLABORATOR_GUIDE.md

@@ -99,7 +99,8 @@ As soon as the PR is ready to land, please do so. Landing your own pull requests
 allows other Collaborators to focus on other pull requests. If your pull request
 is still awaiting the [minimum time to land](#waiting-for-approvals), add the
 `author ready` label so other Collaborators know it can land as soon as the time
-ends.
+ends. If instead you wish to land the PR yourself, indicate this intent by using
+the "assign yourself" button, to self assign the PR. 


typo: self-assign

addaleax · 2018-10-06T16:43:01Z

COLLABORATOR_GUIDE.md

@@ -504,12 +505,15 @@ The TSC should serve as the final arbiter where required.

 ## Landing Pull Requests

+1. Avoid landing PRs that are assigned to someone else. Authors who wish to land
+   their own PRs will self assign them, or delegate to someone else.


“If in doubt, ask the assignee whether it is okay to land?”

Trott

LGTM. A handful of nits/suggestions. Use as you see fit.

Trott · 2018-10-12T00:03:19Z

COLLABORATOR_GUIDE.md

@@ -99,7 +99,8 @@ As soon as the PR is ready to land, please do so. Landing your own pull requests
 allows other Collaborators to focus on other pull requests. If your pull request
 is still awaiting the [minimum time to land](#waiting-for-approvals), add the
 `author ready` label so other Collaborators know it can land as soon as the time
-ends.
+ends. If instead you wish to land the PR yourself, indicate this intent by using
+the "assign yourself" button, to self-assign the PR. 


Maybe just this?:

If you wish to land the PR yourself, use the "assign yourself" button to self-assign the PR.

Trott · 2018-10-12T00:04:06Z

COLLABORATOR_GUIDE.md

@@ -504,12 +505,16 @@ The TSC should serve as the final arbiter where required.

 ## Landing Pull Requests

+1. Avoid landing PRs that are assigned to someone else. Authors who wish to land
+   their own PRs will self-assign them, or delegate to someone else. If in
+   doubt, ask the assignee whether it is okay to land?


land? -> land.

Trott · 2018-10-12T00:06:40Z

COLLABORATOR_GUIDE.md

+   * The "Create a merge commit" method will add an unnecessary merge commit.
+   * The "Squash and merge" method will add metadata (the PR #) to the commit
+     title, and if more than one author has contributed to the PR, squashing
+     will only keep the most recent author when squashing.


Maybe this?:

The "Squash and merge" method will add metadata (the PR #) to the commit title. If more than one author has contributed to the PR, squashing will only keep the most recent author.

If you don't like that and prefer the existing wording, then my comment is to please remove when squashing in squashing will only keep the most recent author when squashing.

Trott · 2018-10-12T00:09:02Z

COLLABORATOR_GUIDE.md

-are correct before merging.
+For PRs from first time contributors it is recommended to be
+[welcoming](#welcoming-first-time-contributors) and verify that the git settings
+are to their liking.


How about this?:

For PRs from first time contributors, be [welcoming](#welcoming-first-time-contributors). Also, verify that their git settings are to their liking.

PR-URL: nodejs#23292 Refs: nodejs#23249 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

refack · 2018-10-13T22:46:57Z

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1238/

PR-URL: #23292 Refs: #23249 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

refack added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Oct 6, 2018

refack self-assigned this Oct 6, 2018

refack requested review from Trott, gireeshpunathil, BridgeAR and vsemozhetbyt October 6, 2018 14:47

refack changed the title * docs,meta: assign PR semantics docs,meta: assign PR semantics Oct 6, 2018

targos approved these changes Oct 6, 2018

View reviewed changes

vsemozhetbyt approved these changes Oct 6, 2018

View reviewed changes

mscdex reviewed Oct 6, 2018

View reviewed changes

refack force-pushed the colab-guide-refresh branch 2 times, most recently from 4784d75 to 3a68aaf Compare October 6, 2018 16:25

addaleax approved these changes Oct 6, 2018

View reviewed changes

trivikr approved these changes Oct 6, 2018

View reviewed changes

refack force-pushed the colab-guide-refresh branch from 6c2c16f to c254e71 Compare October 12, 2018 00:07

Trott approved these changes Oct 12, 2018

View reviewed changes

refack force-pushed the colab-guide-refresh branch from c254e71 to 33f7e58 Compare October 12, 2018 00:10

refack added 2 commits October 13, 2018 18:46

refack force-pushed the colab-guide-refresh branch from 33f7e58 to fc0da7f Compare October 13, 2018 22:46

refack merged commit fc0da7f into nodejs:master Oct 13, 2018

refack deleted the colab-guide-refresh branch October 13, 2018 22:54

refack removed their assignment Oct 20, 2018

codebytere mentioned this pull request Nov 27, 2018

v10.13.1 proposal #24675

Closed

codebytere mentioned this pull request Nov 29, 2018

v10.14.2 proposal #24727

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs,meta: assign PR semantics #23292

docs,meta: assign PR semantics #23292

refack commented Oct 6, 2018

nodejs-github-bot commented Oct 6, 2018

vsemozhetbyt Oct 6, 2018 •

edited

Loading

refack Oct 6, 2018

vsemozhetbyt commented Oct 6, 2018

mscdex Oct 6, 2018

refack Oct 6, 2018

mscdex Oct 6, 2018

refack Oct 6, 2018

vsemozhetbyt commented Oct 6, 2018 •

edited

Loading

addaleax Oct 6, 2018

addaleax Oct 6, 2018

Trott left a comment

Trott Oct 12, 2018

Trott Oct 12, 2018

refack Oct 13, 2018

Trott Oct 12, 2018

refack Oct 13, 2018

Trott Oct 12, 2018 •

edited

Loading

refack Oct 13, 2018

refack commented Oct 13, 2018

docs,meta: assign PR semantics #23292

docs,meta: assign PR semantics #23292

Conversation

refack commented Oct 6, 2018

Checklist

nodejs-github-bot commented Oct 6, 2018

vsemozhetbyt Oct 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vsemozhetbyt commented Oct 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vsemozhetbyt commented Oct 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Trott left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Trott Oct 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

refack commented Oct 13, 2018

vsemozhetbyt Oct 6, 2018 •

edited

Loading

vsemozhetbyt commented Oct 6, 2018 •

edited

Loading

Trott Oct 12, 2018 •

edited

Loading