Skip to content

src: remove accidentally added src/txt #23273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: remove accidentally added src/txt #23273

wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Oct 5, 2018

Refs: #23072

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 5, 2018

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1128/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 5, 2018
@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 5, 2018
@joyeecheung
Copy link
Member Author

joyeecheung commented Oct 5, 2018

Adding fast-track label, please thumb up if you are +1

@joyeecheung joyeecheung requested a review from TimothyGu October 5, 2018 10:14
@joyeecheung
Copy link
Member Author

joyeecheung commented Oct 5, 2018

(I don't think we need to run the full CI for this, do we?)

@joyeecheung
Copy link
Member Author

joyeecheung commented Oct 5, 2018

Landed in e1d4b0a

@joyeecheung joyeecheung closed this Oct 5, 2018
joyeecheung added a commit that referenced this pull request Oct 5, 2018
@joyeecheung
src: remove accidentally added src/txt
e1d4b0a 
PR-URL: #23273
Refs: #23072
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@joyeecheung @jasnell
src: remove accidentally added src/txt
6580ce5 
PR-URL: #23273
Refs: #23072
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@TimothyGu TimothyGu Awaiting requested review from TimothyGu

+2 more reviewers

@danbev danbev danbev approved these changes

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@joyeecheung @nodejs-github-bot @danbev @targos @cjihrig @richardlau @devsnek