Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick V8 changes to extend hash seed to 64-bit #23264

Closed
wants to merge 1 commit into from

Commits on Oct 5, 2018

  1. deps: V8: cherry-pick 64-bit hash seed commits

    This serves as mitigation for the so-called HashWick vulnerability.
    
    Original commit messages:
    
      commit 3833fef57368c53c6170559ffa524c8c69f16ee5
        Author: Yang Guo <yangguo@chromium.org>
        Date: Thu Sep 20 11:43:13 2018
    
        Refactor integer hashing function names
    
        We now clearly differentiate between:
        - unseeded hash for 32-bit integers
        - unseeded hash for 64-bit integers
        - seeded hash for 32-bit integers
        - seeded hash for strings
    
        R=bmeurer@chromium.org
    
        Bug: chromium:680662
        Change-Id: I7459958c4158ee3501c962943dff8f33258bb5ce
        Reviewed-on: https://chromium-review.googlesource.com/1235973
        Commit-Queue: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#56068}
    
      commit 95a979e02d7154e45b293261a6998c99d71fc238
        Author: Yang Guo <yangguo@chromium.org>
        Date: Thu Sep 20 14:34:48 2018
    
        Call into C++ to compute seeded integer hash
    
        R=bmeurer@chromium.org
    
        Bug: chromium:680662
        Change-Id: I8dace89d576dfcc5833fd539ce698a9ade1cb5a0
        Reviewed-on: https://chromium-review.googlesource.com/1235928
        Commit-Queue: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#56091}
    
      commit 2c2af0022d5feb9e525a00a76cb15db9f3e38dba
        Author: Yang Guo <yangguo@chromium.org>
        Date: Thu Sep 27 16:37:57 2018
    
        Use 64-bit for seeded integer hashes
    
        R=petermarshall@chromium.org
    
        Bug: chromium:680662
        Change-Id: If48d1043dbe1e1bb695ec890c23e103a6cacf2d4
        Reviewed-on: https://chromium-review.googlesource.com/1244220
        Commit-Queue: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Peter Marshall <petermarshall@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#56271}
    
    Refs: nodejs#23259
    hashseed committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    c971fd4 View commit details
    Browse the repository at this point in the history