Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "util: change util.inspect depth default" #23231

Closed
wants to merge 1 commit into from
Closed

Revert "util: change util.inspect depth default" #23231

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Oct 3, 2018

This reverts commits:
ac7450a
1a1fe53

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@refack refack requested a review from BridgeAR October 3, 2018 01:13
@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1106/pipeline

@nodejs-github-bot nodejs-github-bot added repl Issues and PRs related to the REPL subsystem. util Issues and PRs related to the built-in util module. labels Oct 3, 2018
@refack refack mentioned this pull request Oct 3, 2018
Closed
4 tasks
@refack
Copy link
Contributor Author

refack commented Oct 3, 2018 •
edited
Loading

Probably due to some PR/PR interaction master is red.
https://travis-ci.com/nodejs/node/builds

Please 👍 to fast-track

current-head: https://ci.nodejs.org/job/node-test-commit/21979/
bisect hot spot: https://ci.nodejs.org/job/node-test-commit/21983/
CI this: https://ci.nodejs.org/job/node-test-commit/21985/

@refack refack added fast-track PRs that do not need to wait for 48 hours to land. regression Issues related to regressions. labels Oct 3, 2018
@cjihrig cjihrig mentioned this pull request Oct 3, 2018
Closed
@cjihrig
Copy link
Contributor

cjihrig commented Oct 3, 2018

Potential fix? #23232

@refack
Copy link
Contributor Author

refack commented Oct 3, 2018

Abandon in favor of #23232

@refack refack closed this Oct 3, 2018
@refack refack added blocked PRs that are blocked by other issues or PRs. and removed fast-track PRs that do not need to wait for 48 hours to land. regression Issues related to regressions. labels Oct 3, 2018
@refack refack deleted the fix-master-regression branch October 3, 2018 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. repl Issues and PRs related to the REPL subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@refack @nodejs-github-bot @cjihrig @Trott