Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed minor typo (to early -> too early) #23211

Closed
wants to merge 2 commits into from
Closed

Fixed minor typo (to early -> too early) #23211

wants to merge 2 commits into from

Conversation

justin0022
Copy link
Contributor

Small change, fixed a typo from 'to early' to 'too early'.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 2, 2018
Trott
Trott approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to include both commits in this one PR? The #vcbuildbat one seems like a correct change but unrelated. Looks like you committed to your own master branch rather than a feature branch, so maybe that's part of the problem?

@justin0022
Copy link
Contributor Author

Hi Trott, my mistake, I meant to create a branch but pushed my change before I did so. Did you want me to break it up into two pull requests? Pretty minor changes.

@Trott
Copy link
Member

Trott commented Oct 2, 2018

Hi Trott, my mistake, I meant to create a branch but pushed my change before I did so. Did you want me to break it up into two pull requests? Pretty minor changes.

My opinion only, but I'm fine with it the way it is. Both changes are very small, narrow, and should be uncontroversial.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1095/

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 2, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 2, 2018
vsemozhetbyt pushed a commit that referenced this pull request Oct 2, 2018
@justin0022 @vsemozhetbyt
doc: fix minor typo (to early -> too early)
9b00c84 
PR-URL: #23211
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
vsemozhetbyt pushed a commit that referenced this pull request Oct 2, 2018
@justin0022 @vsemozhetbyt
doc: fix incorrect anchoring (#vcbuild.bat -> #vcbuildbat)
250957b 
PR-URL: #23211
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in 9b34dfe...250957b
Thank you!

targos pushed a commit that referenced this pull request Oct 3, 2018
@justin0022 @targos
doc: fix minor typo (to early -> too early)
ce006eb 
PR-URL: #23211
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 3, 2018
@justin0022 @targos
doc: fix incorrect anchoring (#vcbuild.bat -> #vcbuildbat)
548934d 
PR-URL: #23211
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@lundibundi lundibundi lundibundi approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@justin0022 @Trott @vsemozhetbyt @lpinca @gireeshpunathil @lundibundi @nodejs-github-bot