doc: edit fast-tracking section #23059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
approved these changes
Sep 24, 2018
lundibundi
approved these changes
Sep 24, 2018
lpinca
approved these changes
Sep 24, 2018
vsemozhetbyt
approved these changes
Sep 24, 2018
vsemozhetbyt
added
the
author ready
BridgeAR
approved these changes
Sep 24, 2018
tniessen
approved these changes
Sep 24, 2018
jasnell
approved these changes
Sep 24, 2018
addaleax
approved these changes
Sep 24, 2018
mihalskiy
approved these changes
Sep 24, 2018
|
CI: https://ci.nodejs.org/job/node-test-pull-request/17429/ There was a failure in parallel/test-tls-connect-simple on ARM, but this is a docs only change. |
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/17432/ (By the way, for doc-only changes, you can use node-test-pull-request-lite-pipeline.) |
|
Pipeline CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1014/ (Resume build was not successful and CI, in general, is not really healthy so I don't think it's worth trying to "green" it). |
|
Just to check CI health resume original again: https://ci.nodejs.org/job/node-test-commit/21772/ (✔️) |
trivikr
approved these changes
Sep 26, 2018
PR-URL: nodejs#23059 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 27, 2018
PR-URL: #23059 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes