Skip to content

[v10.x] process: generate list of allowed env flags programmatically #22847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[v10.x] process: generate list of allowed env flags programmatically #22847

wants to merge 3 commits into from

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Sep 13, 2018 •
edited
Loading

Backport of #22638 with a teeny tiny adjustment (the fixup commits adds a 2 to a regex in the test file to accomodate --expose-http2) – otherwise clean cherry-picks

@addaleax
process: generate list of allowed env flags programmatically
b8321bf 
Avoids having a separate, second source of truth on this matter.

PR-URL: nodejs#22638
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax
lib: generate allowedNodeEnvironmentFlags lazily
c7b8ad8 
PR-URL: nodejs#22638
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax
fixup! process: generate list of allowed env flags programmatically
277b3c5
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 13, 2018

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/884/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v10.x labels Sep 13, 2018
targos pushed a commit that referenced this pull request Sep 15, 2018
@addaleax @targos
process: generate list of allowed env flags programmatically
1e07002 
Avoids having a separate, second source of truth on this matter.

Backport-PR-URL: #22847
PR-URL: #22638
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 15, 2018
@addaleax @targos
lib: generate allowedNodeEnvironmentFlags lazily
a793163 
Backport-PR-URL: #22847
PR-URL: #22638
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos
Copy link
Member

targos commented Sep 15, 2018

Landed in 1e07002 and a793163. Thanks!

@targos targos closed this Sep 15, 2018
targos pushed a commit that referenced this pull request Sep 19, 2018
@addaleax @targos
process: generate list of allowed env flags programmatically
cfced0c 
Avoids having a separate, second source of truth on this matter.

Backport-PR-URL: #22847
PR-URL: #22638
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 19, 2018
@addaleax @targos
lib: generate allowedNodeEnvironmentFlags lazily
60dc374 
Backport-PR-URL: #22847
PR-URL: #22638
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 20, 2018
@addaleax @targos
process: generate list of allowed env flags programmatically
4ab9d6f 
Avoids having a separate, second source of truth on this matter.

Backport-PR-URL: #22847
PR-URL: #22638
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 20, 2018
@addaleax @targos
lib: generate allowedNodeEnvironmentFlags lazily
2abdbf4 
Backport-PR-URL: #22847
PR-URL: #22638
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@addaleax @nodejs-github-bot @targos