test: fix fs.readFile('/dev/stdin') tests #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
lgtm also, FYI these tests started failing after I put the build directories on an NFS share, changing the I/O profile of the disks |
|
Ah nice catch, LGTM |
The tests were creating the temp fixture file in both the parent and the child process, leading to interesting race conditions on the slower buildbots. Rod notes that the tests started failing after putting the build directory on a NFS mount. Fixes: nodejs#2261 PR-URL: nodejs#2265 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis
force-pushed
the
fix-readfile-pipe-tests
branch
from
96da915
to
bc733f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were creating the temp fixture file in both the parent
and the child process, leading to interesting race conditions on
the slower buildbots.
R=@Fishrock123
CI: https://jenkins-iojs.nodesource.com/job/node-test-pull-request/21/
Previous ARM-only run: https://jenkins-iojs.nodesource.com/job/iojs+pr+arm/192/
[Note to self: add link to https://github.com//issues/2261 in commit log.]