Skip to content

src: fix a typo in the comment #22640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: fix a typo in the comment #22640

wants to merge 1 commit into from

Conversation

@gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Sep 1, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
    no need to depends -> no need to depend

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 1, 2018

@gireeshpunathil build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/758/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 1, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Sep 1, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

mohammed-adil-moughal
mohammed-adil-moughal approved these changes Sep 1, 2018
View reviewed changes
Copy link

@mohammed-adil-moughal mohammed-adil-moughal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 1, 2018
gireeshpunathil added a commit that referenced this pull request Sep 3, 2018
@gireeshpunathil
src: fix a typo in the comment
1f67910 
PR-URL: #22640
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gireeshpunathil
Copy link
Member Author

gireeshpunathil commented Sep 3, 2018

landed in 1f67910

targos pushed a commit that referenced this pull request Sep 3, 2018
@gireeshpunathil @targos
src: fix a typo in the comment
516d71a 
PR-URL: #22640
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@gireeshpunathil @targos
src: fix a typo in the comment
d8fff06 
PR-URL: #22640
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+2 more reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@mohammed-adil-moughal mohammed-adil-moughal mohammed-adil-moughal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@gireeshpunathil @nodejs-github-bot @vsemozhetbyt @lpinca @targos @cjihrig @richardlau @BridgeAR @mohammed-adil-moughal