crypto: deduplicate public key parsing #22553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
cc @nodejs/crypto |
addaleax
approved these changes
Aug 28, 2018
src/node_crypto.cc
Outdated
| @@ -3648,6 +3648,45 @@ void Sign::SignFinal(const FunctionCallbackInfo<Value>& args) { | |||
| args.GetReturnValue().Set(rc); | |||
| } | |||
|
|
|||
| typedef enum { | |||
There was a problem hiding this comment.
No need to typedef, enum ParsePublicKeyResult works too :)
tniessen
added
the
author ready
|
The last two CI builds passed according to Jenkins, but GH is still displaying pending / failed. cc @nodejs/build |
|
Landed in 83f319c |
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
PR-URL: #22553 Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
PR-URL: #22553 Reviewed-By: Anna Henningsen <anna@addaleax.net>
4 tasks
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22553 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
PR-URL: #22553 Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Sep 6, 2018
tniessen
removed
the
author ready
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight reduction in SLOC by deduplicating public key parsing in the crypto module as suggested in a comment in lines 3715 to 3717. There should be no functional difference.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes