New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,deps: backport and use non-deprecated V8 methods with isolate #22531

Closed

targos wants to merge 6 commits into nodejs:master from targos:v8-isolate-everywhere

Member

targos commented Aug 26, 2018

Follow-up to #22521

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Collaborator

nodejs-github-bot commented Aug 26, 2018

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/677/pipeline

nodejs-github-bot added c++ lib / src labels

cjihrig approved these changes

View reviewed changes

Member Author

targos commented Aug 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16781/

danbev approved these changes

View reviewed changes

addaleax approved these changes

View reviewed changes

jasnell approved these changes

View reviewed changes

Member Author

targos commented Aug 28, 2018

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20331/

targos added 6 commits

August 29, 2018 12:23


          deps: backport StackFrame::GetFrame with isolate

64154c3

This overload was added in V8 6.9 and the one without isolate was
removed in V8 7.0.

Refs: v8/v8@8a011b5


          src: use StackFrame::GetFrame with isolate

bafe937


          deps: backport String::Write{OneByte,Utf8} with isolate

845bf71

These overloads were added in V8 6.9 and the ones without the isolate
parameter were removed in V8 7.0.

Refs: v8/v8@8a011b5


          src: use String::Write{OneByte,Utf8} with isolate

85833b1


          deps: backport String::Utf8Length with isolate

761c0a0

This overload was added in V8 6.9 and the one without the isolate
parameter was removed in V8 7.0.

Refs: v8/v8@3dd5c6f


          src: use String::Utf8Length with isolate

fc0b211

targos force-pushed the v8-isolate-everywhere branch from 9508242 to fc0b211 Compare

August 29, 2018 10:25

targos added a commit to targos/node that referenced this pull request


          deps: backport StackFrame::GetFrame with isolate

487c1e0

This overload was added in V8 6.9 and the one without isolate was
removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request


          src: use StackFrame::GetFrame with isolate

30c7946

PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request


          deps: backport String::Write{OneByte,Utf8} with isolate

7c84489

These overloads were added in V8 6.9 and the ones without the isolate
parameter were removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request


          src: use String::Write{OneByte,Utf8} with isolate

a64fd7f

PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request


          deps: backport String::Utf8Length with isolate

17dd620

This overload was added in V8 6.9 and the one without the isolate
parameter was removed in V8 7.0.

Refs: v8/v8@3dd5c6f

PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request


          src: use String::Utf8Length with isolate

b2f0cfa

PR-URL: nodejs#22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

Member Author

targos commented Aug 29, 2018

Landed in 2584052...b2f0cfa

targos closed this

targos added the v8 engine label

targos deleted the v8-isolate-everywhere branch

August 29, 2018 10:39

targos added dont-land-on-v6.x labels

targos added a commit that referenced this pull request


          deps: backport StackFrame::GetFrame with isolate

fd991cf

This overload was added in V8 6.9 and the one without isolate was
removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          src: use StackFrame::GetFrame with isolate

a6af5df

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          deps: backport String::Write{OneByte,Utf8} with isolate

07f06d8

These overloads were added in V8 6.9 and the ones without the isolate
parameter were removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          src: use String::Write{OneByte,Utf8} with isolate

f0840e3

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          deps: backport String::Utf8Length with isolate

c261176

This overload was added in V8 6.9 and the one without the isolate
parameter was removed in V8 7.0.

Refs: v8/v8@3dd5c6f

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          src: use String::Utf8Length with isolate

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          deps: backport StackFrame::GetFrame with isolate

3dc9cfc

This overload was added in V8 6.9 and the one without isolate was
removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          src: use StackFrame::GetFrame with isolate

9478f29

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          deps: backport String::Write{OneByte,Utf8} with isolate

d50e1ff

These overloads were added in V8 6.9 and the ones without the isolate
parameter were removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          src: use String::Write{OneByte,Utf8} with isolate

8375f75

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          deps: backport String::Utf8Length with isolate

5f44ce8

This overload was added in V8 6.9 and the one without the isolate
parameter was removed in V8 7.0.

Refs: v8/v8@3dd5c6f

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          src: use String::Utf8Length with isolate

332b035

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos mentioned this pull request

Release proposal: v10.10.0 #22716

Merged

targos added a commit that referenced this pull request


          deps: backport StackFrame::GetFrame with isolate

76806e9

This overload was added in V8 6.9 and the one without isolate was
removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          src: use StackFrame::GetFrame with isolate

9efa76f

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          deps: backport String::Write{OneByte,Utf8} with isolate

9140edf

These overloads were added in V8 6.9 and the ones without the isolate
parameter were removed in V8 7.0.

Refs: v8/v8@8a011b5

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          src: use String::Write{OneByte,Utf8} with isolate

f576425

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          deps: backport String::Utf8Length with isolate

83343f7

This overload was added in V8 6.9 and the one without the isolate
parameter was removed in V8 7.0.

Refs: v8/v8@3dd5c6f

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request


          src: use String::Utf8Length with isolate

12f5480

PR-URL: #22531
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced Sep 6, 2018

2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-android-nodejs#236

Closed

2018-09-06 Version 10.10.0 (Current) @targos beevelop/docker-nodejs#221

Closed

Flarna mentioned this pull request

WriteUtf8 does not take 5 arguments nodejs/nan#832

Closed

richardlau added a commit to richardlau/nodereport that referenced this pull request


          Fix use of deprecated methods removed in V8 7.0

StackFrame::GetFrame(uint32_t index) was deprecated in V8 6.9 and
removed in V8 7.0.

Refs: nodejs/node#22531
Refs: nodejs#116

richardlau mentioned this pull request

Fix use of deprecated methods removed in V8 7.0 nodejs/node-report#119

Merged

richardlau added a commit to richardlau/nodereport that referenced this pull request


          Fix use of deprecated methods removed in V8 7.0

26f88d0

StackFrame::GetFrame(uint32_t index) was deprecated in V8 6.9 and
removed in V8 7.0.

PR-URL: nodejs#119
Refs: nodejs/node#22531
Refs: nodejs#116
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ lib / src v8 engine