Skip to content

src: deprecate option variables in public API #22515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

src: deprecate option variables in public API #22515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,17 @@ typedef intptr_t ssize_t;

namespace node {

// TODO(addaleax): Deprecate and remove all of these ASAP. They have been
// made effectively non-functional anyway.
NODE_EXTERN extern bool no_deprecation;
// TODO(addaleax): Remove all of these.
NODE_DEPRECATED("use command-line flags",
NODE_EXTERN extern bool no_deprecation);
#if HAVE_OPENSSL
NODE_EXTERN extern bool ssl_openssl_cert_store;
NODE_DEPRECATED("use command-line flags",
NODE_EXTERN extern bool ssl_openssl_cert_store);
# if NODE_FIPS_MODE
NODE_EXTERN extern bool enable_fips_crypto;
NODE_EXTERN extern bool force_fips_crypto;
NODE_DEPRECATED("use command-line flags",
NODE_EXTERN extern bool enable_fips_crypto);
NODE_DEPRECATED("user command-line flags",
NODE_EXTERN extern bool force_fips_crypto);
# endif
#endif

Expand Down
5 changes: 3 additions & 2 deletions src/node_buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@

namespace node {

// TODO(addaleax): Deprecate and remove this ASAP.
extern bool zero_fill_all_buffers;
// TODO(addaleax): Remove this.
NODE_DEPRECATED("use command-line flags",
extern bool zero_fill_all_buffers);

namespace Buffer {

Expand Down