test: improve assertions in test-cli-node-print-help #22489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Aug 23, 2018
lpinca
approved these changes
Aug 24, 2018
refack
reviewed
Aug 24, 2018
| cliHelpOptions.forEach(testForSubstring); | ||
| } | ||
|
|
||
| function testForSubstring(options) { |
There was a problem hiding this comment.
could we add:
{ compileConstant: true,
flags: [
'-',
'--',
'--abort-on-uncaught-exception',
'-c',
'--check',
'-e',
'--eval script',
'--experimental-modules',
'--experimental-repl-await',
'--experimental-vm-modules',
'-h',
'--help',
'-i',
'--interactive',
'--napi-modules',
'--no-deprecation',
'--no-force-async-hooks-checks',
'--no-warnings',
'-p',
'--pending-deprecation',
'--preserve-symlinks',
'--preserve-symlinks-main',
'--print',
'--prof',
'--prof-process',
'-r',
'--redirect-warnings=file',
'--require',
'--throw-deprecation',
'--trace-deprecation',
'--trace-event-categories',
'--trace-event-file-pattern',
'--trace-events-enabled',
'--trace-sync-io',
'--trace-warnings',
'--track-heap-objects',
'-v',
'--v8-options',
'--v8-pool-size=num',
'--version',
'--zero-fill-buffers',
'NODE_DEBUG',
'NODE_DEBUG_NATIVE',
'NODE_DISABLE_COLORS',
'NODE_EXTRA_CA_CERTS',
'NODE_NO_WARNINGS',
'NODE_OPTIONS',
'NODE_PATH',
'NODE_PENDING_DEPRECATION',
'NODE_PRESERVE_SYMLINKS',
'NODE_REDIRECT_WARNINGS',
'NODE_REPL_HISTORY',
'OPENSSL_CONF',
]
}
There was a problem hiding this comment.
If you submit a PR with that I’ll approve it, yes.
refack
approved these changes
Aug 24, 2018
refack
added
the
cli
addaleax
added
the
author ready
|
Landed in 208022c |
addaleax
added a commit
that referenced
this pull request
Sep 2, 2018
PR-URL: #22489 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 2, 2018
PR-URL: #22489 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22489 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
PR-URL: #22489 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes