Skip to content

zlib: alter wrong argument number error message #22130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

zlib: alter wrong argument number error message #22130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/node_zlib.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,9 +431,20 @@ class ZCtx : public AsyncWrap, public ThreadPoolWork {
"a version of npm (> 5.5.1 or < 5.4.0) or node-tar (> 4.0.1) "
"that is compatible with Node.js 9 and above.\n");
}
CHECK(args.Length() == 7 &&
"init(windowBits, level, memLevel, strategy, writeResult, writeCallback,"
" dictionary)");
// Refs: https://github.com/nodejs/node/issues/16987
if (args.Length() != 7) {
// Cloned from util.h
const char* const args[] = {__FILE__,
STRINGIFY(__LINE__ - 4),
// The -4 in the previous line makes it
// possible to refer to the actual line of
// the condition.
"args.Length() == 7 && init(windowBits,"
"level, memLevel, strategy, writeResult,"
" writeCallback, dictionary)",
""};
node::Assert(&args);
}

ZCtx* ctx;
ASSIGN_OR_RETURN_UNWRAP(&ctx, args.Holder());
Expand Down