doc,assert: rename stackStartFunction #22077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[assert.js](https://github.com/nodejs/node/blob/master/lib/assert.js) uses `stackStartFn` everywhere instead of `stackStartFunction`. This also increases consistency with `stackStartFn` in the `AssertionError` options.
nodejs-github-bot
added
assert
BridgeAR
approved these changes
Aug 1, 2018
Trott
approved these changes
Aug 2, 2018
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM, although honestly, I'd prefer going to the more verbose stackStartFunction if there's no downside.
Member
|
Welcome, @eyqs, and thanks for the PR! |
Contributor
Author
|
I agree that it would be better for everything to use |
trivikr
approved these changes
Aug 2, 2018
vsemozhetbyt
approved these changes
Aug 2, 2018
Contributor
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
lpinca
approved these changes
Aug 2, 2018
vsemozhetbyt
added
fast-track
Contributor
|
Landed in ce98e2e |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Aug 2, 2018
[assert.js](https://github.com/nodejs/node/blob/master/lib/assert.js) uses `stackStartFn` everywhere instead of `stackStartFunction`. This also increases consistency with `stackStartFn` in the `AssertionError` options. PR-URL: #22077 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2018
[assert.js](https://github.com/nodejs/node/blob/master/lib/assert.js) uses `stackStartFn` everywhere instead of `stackStartFunction`. This also increases consistency with `stackStartFn` in the `AssertionError` options. PR-URL: #22077 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert.js uses
stackStartFneverywhere instead ofstackStartFunction. This also increases consistency withstackStartFnin theAssertionErroroptions.Checklist