Skip to content

test: Refactor test-http2-compat-serverresponse-finished.js #21929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: Refactor test-http2-compat-serverresponse-finished.js #21929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/parallel/test-http2-compat-serverresponse-finished.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ const net = require('net');

// Http2ServerResponse.finished
const server = h2.createServer();
server.listen(0, common.mustCall(function() {
server.listen(0, common.mustCall(() => {
const port = server.address().port;
server.once('request', common.mustCall(function(request, response) {
server.once('request', common.mustCall((request, response) => {
assert.ok(response.socket instanceof net.Socket);
assert.ok(response.connection instanceof net.Socket);
assert.strictEqual(response.socket, response.connection);

response.on('finish', common.mustCall(function() {
response.on('finish', common.mustCall(() => {
assert.strictEqual(response.socket, undefined);
assert.strictEqual(response.connection, undefined);
process.nextTick(common.mustCall(() => {
Expand All @@ -30,15 +30,15 @@ server.listen(0, common.mustCall(function() {
}));

const url = `http://localhost:${port}`;
const client = h2.connect(url, common.mustCall(function() {
const client = h2.connect(url, common.mustCall(() => {
const headers = {
':path': '/',
':method': 'GET',
':scheme': 'http',
':authority': `localhost:${port}`
};
const request = client.request(headers);
request.on('end', common.mustCall(function() {
request.on('end', common.mustCall(() => {
client.close();
}));
request.end();
Expand Down