-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: allow tests to pass without internet #21909
Conversation
Please thumbs up here if you are OK with fast tracking this and i will land it. |
It's probably a good idea to run the |
Internet run: https://ci.nodejs.org/job/node-test-commit-custom-suites/138/ |
@Trott thanks for running those. I poked around CI when @richardlau mentioned running just one suite, and doing that was non-obvious. After consulting the collaborator guide it was still non-obvious. I know that due to my intermittent presence here, things can change. Is there any place this test suite is documented? After taking a look at the build job parameters it seems pretty straightforward. But, tbqh, I really didn't have any idea what to do when @richardlau mentioned it above. |
Landed in 2058a1c |
PR-URL: #21909 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #21909 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE. Refs: nodejs#21909 (comment)
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE. Refs: nodejs#21909 (comment) PR-URL: nodejs#21927 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE. Refs: #21909 (comment) PR-URL: #21927 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Currently when running the test without an internet connection the following error appears:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes