Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: allow tests to pass without internet #21909

Closed
wants to merge 1 commit into from
Closed

test: allow tests to pass without internet #21909

wants to merge 1 commit into from

Conversation

helio-frota
Copy link
Contributor

Currently when running the test without an internet connection the following error appears:

=== release test-dns-promises-resolve ===                                      
Path: parallel/test-dns-promises-resolve
(node:12455) ExperimentalWarning: The dns.promises API is experimental
/opt/app-root/src/node/test/common/index.js:820
             (err) => process.nextTick(() => { throw err; }));
                                               ^

Error: queryA ETIMEOUT example.org
    at QueryReqWrap.onresolve [as oncomplete] (internal/dns/promises.js:163:17)
Command: out/Release/node /opt/app-root/src/node/test/parallel/test-dns-promises-resolve.js
[06:30|% 100|+ 2354|-   1]: Done                                               
make[1]: *** [jstest] Error 1
make: *** [test] Error 2
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@lance
Copy link
Member

lance commented Jul 20, 2018

Please thumbs up here if you are OK with fast tracking this and i will land it.

@lance
Copy link
Member

lance commented Jul 20, 2018

@richardlau
Copy link
Member

Please thumbs up here if you are OK with fast tracking this and i will land it.

It's probably a good idea to run the internet suite of tests to make sure they're green seeing as they're not run as part of the regular CI.

@Trott
Copy link
Member

Trott commented Jul 20, 2018

It's probably a good idea to run the internet suite of tests to make sure they're green seeing as they're not run as part of the regular CI.

Internet run: https://ci.nodejs.org/job/node-test-commit-custom-suites/138/

@lance
Copy link
Member

lance commented Jul 21, 2018

@Trott thanks for running those. I poked around CI when @richardlau mentioned running just one suite, and doing that was non-obvious.

Default CI View

After consulting the collaborator guide it was still non-obvious.

I know that due to my intermittent presence here, things can change. Is there any place this test suite is documented? After taking a look at the build job parameters it seems pretty straightforward. But, tbqh, I really didn't have any idea what to do when @richardlau mentioned it above.

@lance
Copy link
Member

lance commented Jul 21, 2018

Landed in 2058a1c

@lance lance closed this Jul 21, 2018
lance pushed a commit that referenced this pull request Jul 21, 2018
PR-URL: #21909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott
Copy link
Member

Trott commented Jul 21, 2018

Is there any place this test suite is documented?

@lance #21927

targos pushed a commit that referenced this pull request Jul 21, 2018
PR-URL: #21909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@helio-frota helio-frota deleted the internet-tests branch July 21, 2018 20:22
Trott added a commit to Trott/io.js that referenced this pull request Jul 23, 2018
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: nodejs#21909 (comment)
Trott added a commit to Trott/io.js that referenced this pull request Jul 24, 2018
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: nodejs#21909 (comment)

PR-URL: nodejs#21927
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jul 26, 2018
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: #21909 (comment)

PR-URL: #21927
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants