Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove timeout from test-pipe-stream #21837

Closed
wants to merge 1 commit into from

Commits on Jul 16, 2018

  1. test: remove timeout from test-pipe-stream

    The timeout is unnecessary and the suspected cause of the following
    failure (even though I could not reproduce it locally):
    
        11:53:54 not ok 197 parallel/test-pipe-stream
        11:53:54   ---
        11:53:54   duration_ms: 6.253
        11:53:54   severity: fail
        11:53:54   exitcode: 1
        11:53:54   stack: |-
        11:53:54     assert.js:338
        11:53:54         throw err;
        11:53:54         ^
        11:53:54
        11:53:54     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
        11:53:54
        11:53:54       assert.ok(have_ping)
        11:53:54
        11:53:54         at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12)
        11:53:54         at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5)
        11:53:54         at Server.emit (events.js:182:13)
        11:53:54         at emitCloseNT (net.js:1668:8)
        11:53:54         at process._tickCallback (internal/process/next_tick.js:63:19)
    
    (From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.)
    addaleax committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    c37c013 View commit details
    Browse the repository at this point in the history