Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] test: bypass dns for IPv6 net tests #21736

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] test: bypass dns for IPv6 net tests #21736

wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

PR-URL: #16976
Refs: #16248
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Backport, as requested, of #16976

@nodejs-github-bot
Copy link
Collaborator

@BethGriggs build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/242/pipeline

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Jul 10, 2018
@BethGriggs BethGriggs added the wip Issues and PRs that are still a work in progress. label Jul 10, 2018
@BethGriggs BethGriggs removed the wip Issues and PRs that are still a work in progress. label Jul 10, 2018
@refack @BethGriggs
test: bypass dns for IPv6 net tests
38847dd 
PR-URL: nodejs#16976
Refs: nodejs#16248
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/15807/

@MylesBorins
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/16101/

MylesBorins pushed a commit that referenced this pull request Aug 1, 2018
@refack @MylesBorins
test: bypass dns for IPv6 net tests
1d3ea3f 
Backport-PR-URL: #21736
PR-URL: #16976
Refs: #16248
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins
Copy link
Contributor

Failures known flake now fixed on branch

landed in 1d3ea3f

@MylesBorins MylesBorins closed this Aug 1, 2018
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@refack @rvagg
test: bypass dns for IPv6 net tests
9a9ea0d 
Backport-PR-URL: #21736
PR-URL: #16976
Refs: #16248
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BethGriggs BethGriggs deleted the backport-16976-to-v8.x branch June 11, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BethGriggs @nodejs-github-bot @addaleax @MylesBorins @refack