Closed
Conversation
nodejs-github-bot
added
the
v8 engine
Contributor
Author
Member
|
It doesn’t look like these changes affect us, right? I guess it’s not an issue if you’re a Googler, but if your dev machine is near the lower end, recompiling all of V8 can be a real pain… |
Contributor
Author
|
@addaleax we can hold off on landing this one and wait for changes that are more meaningful, generally trying to just keep us up to date with LKGR. Do these changes force a recompile? |
Member
I guess not, no … seems okay to me then? |
addaleax
approved these changes
Jul 9, 2018
ChALkeR
approved these changes
Jul 11, 2018
BridgeAR
approved these changes
Jul 13, 2018
BridgeAR
added
the
author ready
Contributor
Author
|
landed in 9374a83 |
MylesBorins
added a commit
that referenced
this pull request
Jul 13, 2018
PR-URL: #21727 Refs: v8/v8@6.7.288.46...6.7.288.49 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Jul 14, 2018
PR-URL: #21727 Refs: v8/v8@6.7.288.46...6.7.288.49 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@6.7.288.46...6.7.288.49