src: make Environment::is_stopping_worker inline#21720
Closed
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-worker-inl
Closed
src: make Environment::is_stopping_worker inline#21720maclover7 wants to merge 1 commit intonodejs:masterfrom maclover7:jm-worker-inl
maclover7 wants to merge 1 commit intonodejs:masterfrom
maclover7:jm-worker-inl
Conversation
Fixes a TODO comment.
nodejs-github-bot
added
the
c++
TimothyGu
approved these changes
Jul 9, 2018
Contributor
Author
jasnell
approved these changes
Jul 10, 2018
Contributor
Author
|
Landing... |
Contributor
Author
|
Landed in fcfd3e1 |
maclover7
added a commit
that referenced
this pull request
Jul 11, 2018
Fixes a TODO comment. PR-URL: #21720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2018
Fixes a TODO comment. PR-URL: #21720 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a TODO comment
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes