tools: add no-duplicate-requires rule#21712
Closed
devsnek wants to merge 0 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
the
lib / src
richardlau
approved these changes
Jul 8, 2018
richardlau
reviewed
Jul 8, 2018
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
A test for the custom rule would be good.
devsnek
force-pushed
the
feature/linter-no-duplicate-requires-rule
branch
from
38b0037 to
10d3bb2
Compare
Member
Author
TimothyGu
approved these changes
Jul 9, 2018
doc/api/worker_threads.md
Outdated
Member
There was a problem hiding this comment.
This should instead use worker_threads.parentPort (see #21486). Might be helpful to apply that first.
Member
|
I wonder if this might be subsequently upstreamable to ESLint core. |
starkwang
approved these changes
Jul 9, 2018
devsnek
force-pushed
the
feature/linter-no-duplicate-requires-rule
branch
from
10d3bb2 to
9b92f50
Compare
Member
Author
|
CI after rebasing: https://ci.nodejs.org/job/node-test-pull-request/15779/ |
jasnell
approved these changes
Jul 10, 2018
Member
|
Looks like it needs another rebase due to a PR I just landed. Sorry. |
devsnek
force-pushed
the
feature/linter-no-duplicate-requires-rule
branch
from
9b92f50 to
a1e019b
Compare
addaleax
added
the
author ready
Member
maclover7
approved these changes
Jul 12, 2018
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/15836/ |
Member
|
Windows fanned is "Resume Build"-resistant so here's a Rebuild instead: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19249/ |
Member
|
(All green in CI.) |
Member
Author
|
landed in 8cae9b2 |
devsnek
added a commit
that referenced
this pull request
Jul 12, 2018
PR-URL: #21712 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos
pushed a commit
that referenced
this pull request
Jul 14, 2018
PR-URL: #21712 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
devsnek
force-pushed
the
feature/linter-no-duplicate-requires-rule
branch
from
a1e019b to
e406cca
Compare
This was referenced Jul 18, 2018
targos
removed
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @nodejs/linting
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes