src: add null check to GetCategoryGroupEnabled() #21545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
geek
approved these changes
Jun 26, 2018
addaleax
approved these changes
Jun 26, 2018
danbev
approved these changes
Jun 26, 2018
|
CI: https://ci.nodejs.org/job/node-test-pull-request/15635/ EDIT (cjihrig): The CI was all green. |
addaleax
added
lib / src
lpinca
approved these changes
Jun 26, 2018
tniessen
approved these changes
Jun 26, 2018
The input to this function shouldn't be null, and callers are not equipped to deal with a nullptr return value. Change the nullptr return to a CHECK_NOT_NULL(). Also fix the indentation of the function. PR-URL: nodejs#21545 Fixes: nodejs#19991 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jun 28, 2018
The input to this function shouldn't be null, and callers are not equipped to deal with a nullptr return value. Change the nullptr return to a CHECK_NOT_NULL(). Also fix the indentation of the function. PR-URL: #21545 Fixes: #19991 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input to this function shouldn't be null, and callers are not equipped to deal with a
nullptrreturn value. Change thenullptrreturn to aCHECK_NOT_NULL(). Also fix the indentation of the function.Fixes: #19991
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes